Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5099: [Bug]: When a github token expires, the waiting list screen appears #5100

Closed
wants to merge 2 commits into from

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Nov 18, 2024

This pull request fixes #5099.

The PR successfully addresses the core issue by implementing proper handling of expired GitHub tokens. The key improvements made:

  1. Better user experience: Instead of showing a confusing waitlist screen, users now see a clear "GitHub Token Expired" message
  2. Proper token management: The system now automatically detects and clears expired tokens
  3. Streamlined reconnection: Users are provided with a direct "Reconnect to GitHub" button rather than being sent to a waitlist
  4. Technical implementation: Changes to both waitlist-modal.tsx and _oh.tsx provide a complete solution for token expiration handling

These changes directly solve the reported problem of users being incorrectly shown a waitlist message when their GitHub token expires, and implements the requested solution of properly noting the token expiration and providing a way to enter a new one.

For a human reviewer: This PR implements proper GitHub token expiration handling by updating the UI to show clear expiration messages and adding the necessary token management logic. The changes improve the user experience by eliminating confusion and providing a straightforward path to reconnection when tokens expire.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c7c3b34-nikolaik   --name openhands-app-c7c3b34   docker.all-hands.dev/all-hands-ai/openhands:c7c3b34

@neubig neubig closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When a github token expires, the waiting list screen appears
2 participants