Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate claude-3-5-sonnet-20241022 model from VERIFIED_MODELS #4871

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Nov 9, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Removes duplicate sonnet model from VERIFIED_ANTHROPIC_MODELS since it's already in VERIFIED_MODELS, fixing the double entry in the dropdown menu.

image

Link of any specific issues this addresses

Fix #4653


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:5474d3e-nikolaik   --name openhands-app-5474d3e   docker.all-hands.dev/all-hands-ai/openhands:5474d3e

@xingyaoww xingyaoww changed the title fix: remove duplicate claude-3-5-sonnet-20241022 model from VERIFIED_… fix: remove duplicate claude-3-5-sonnet-20241022 model from VERIFIED_MODELS Nov 9, 2024
@xingyaoww xingyaoww requested a review from amanape November 9, 2024 21:11
@xingyaoww xingyaoww marked this pull request as ready for review November 9, 2024 21:11
"claude-3-5-sonnet-20240620",
"claude-3-haiku-20240307",
"claude-3-opus-20240229",
"claude-3-sonnet-20240229",
"claude-instant-1",
"claude-instant-1.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think claude removed support for these, so we can remove them together

@xingyaoww xingyaoww enabled auto-merge (squash) November 9, 2024 21:17
@xingyaoww xingyaoww merged commit d8ab020 into main Nov 9, 2024
12 of 13 checks passed
@xingyaoww xingyaoww deleted the fix/remove-duplicate-sonnet-model branch November 9, 2024 21:41
@tobitege
Copy link
Collaborator

tobitege commented Nov 11, 2024

@xingyaoww the change causes 2 FE tests to fail, but got merged.
Is this an issue with our workflow or because you're an admin and the auto-merge then ignores the failed tests?

Resolved by 4887

@amanape amanape mentioned this pull request Nov 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AI Provider Configuration UI is showing Sonnet 20241022 twice
4 participants