Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(frontend): Pass failing tests #4887

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 11, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
#4871 introduced two failing frontend tests. I suspect those tests failed because LiteLLM returns the claude-3-5-sonnet-20241022 model string as anthropic/claude-3-5-sonnet-20241022. Our app assumed it did not, and if it were to find the string claude-3-5-sonnet-20241022, to append it manually. This resulted in a duplication. One that is parsed if the string contains a provider, and one that is manually entered for specified models.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Update tests to use a model that does not already contain the provider (for manual parsing tests)
  • Update tests to reflect that the model is expected to contain the provider as well (anthropic/claude-3-5-sonnet-20241022)

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:eda7002-nikolaik   --name openhands-app-eda7002   docker.all-hands.dev/all-hands-ai/openhands:eda7002

@amanape amanape requested a review from tobitege November 11, 2024 09:17
@amanape amanape self-assigned this Nov 11, 2024
Copy link
Collaborator

@tobitege tobitege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤗 LGTM

@amanape amanape enabled auto-merge (squash) November 11, 2024 09:21
@amanape amanape merged commit dd50246 into main Nov 11, 2024
13 checks passed
@amanape amanape deleted the hotfix/failing-model-extractor-tests branch November 11, 2024 09:49
@amanape amanape mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants