Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGCF: add triton and He3 PID to femtodream data model #8123

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

ariedel-cern
Copy link
Collaborator

Add triton and He3 PID to femtodream data model.

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anton, please, have a look at my only comment

Is that everything that is needed to incorporate He3 to the derived data?

Comment on lines 375 to 383
case 1000010020: // Deuteron
pidTPC = part.tpcNSigmaDe();
pidTOF = part.tofNSigmaDe();
break;
case 1000010030: // Triton
pidTPC = part.tpcNSigmaTr();
pidTOF = part.tofNSigmaTr();
break;
case 1000020030: // Helium3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move to use named constants as per
https://github.com/AliceO2Group/AliceO2/blob/dev/Common/Constants/include/CommonConstants/PhysicsConstants.h
it will be less error prone and no comments are needed

As it is commented there, the previous file expands the definitions in <TPDGCode_8.h> as visible in https://root.cern/doc/master/TPDGCode_8h.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor,
yes. I just need to add the PID to the extra tables and some additional histograms. The framework which calculates the bitmask did already support all possible track PIDs.
Thanks for the comment. I swich the PDG codes to the name constants.

@ariedel-cern
Copy link
Collaborator Author

Hi @mfaggin @fgrosa @1994ra ,
I got the request to add triton and He3 PID to the femto dream extra table. Since the femto dream producer in the HFC framework is also subscribing to this table, I had to make a small adjustment (i.e. adding 4 more dummy values in your producer since you only use track PID for proton and lighter particles). As far as I can tell, these changes should not affect the other HF tasks. But it would be good if you could also take a look.

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AntonRiedel I am approving it not to block your work, but I think it would be better to have joinable tables for the PID hypotheses, not to have many unused dummy columns when not needed

@victor-gonzalez
Copy link
Collaborator

@ariedel-cern, @fgrosa made a good point!
Joinable tables will reduce the memory footprint for concrete analyses
I think we should consider it for the ongoing re-organization, if feasible

@victor-gonzalez victor-gonzalez merged commit 94ea5af into AliceO2Group:master Oct 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants