-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGCF: add triton and He3 PID to femtodream data model #8123
PWGCF: add triton and He3 PID to femtodream data model #8123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anton, please, have a look at my only comment
Is that everything that is needed to incorporate He3 to the derived data?
case 1000010020: // Deuteron | ||
pidTPC = part.tpcNSigmaDe(); | ||
pidTOF = part.tofNSigmaDe(); | ||
break; | ||
case 1000010030: // Triton | ||
pidTPC = part.tpcNSigmaTr(); | ||
pidTOF = part.tofNSigmaTr(); | ||
break; | ||
case 1000020030: // Helium3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move to use named constants as per
https://github.com/AliceO2Group/AliceO2/blob/dev/Common/Constants/include/CommonConstants/PhysicsConstants.h
it will be less error prone and no comments are needed
As it is commented there, the previous file expands the definitions in <TPDGCode_8.h>
as visible in https://root.cern/doc/master/TPDGCode_8h.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Victor,
yes. I just need to add the PID to the extra tables and some additional histograms. The framework which calculates the bitmask did already support all possible track PIDs.
Thanks for the comment. I swich the PDG codes to the name constants.
51e07e9
to
3260357
Compare
Hi @mfaggin @fgrosa @1994ra , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonRiedel I am approving it not to block your work, but I think it would be better to have joinable tables for the PID hypotheses, not to have many unused dummy columns when not needed
@ariedel-cern, @fgrosa made a good point! |
Add triton and He3 PID to femtodream data model.