Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request for new workflow femtoDreampHe3ProducerTask.cxx #8109

Closed
wants to merge 0 commits into from

Conversation

blacwovie
Copy link

Tables pidTPCFullHe3 and pidTOFFullHe3 are added in producer task and saved as a new workflow femtoDreampHe3ProducerTask.cxx to producer femto derived data with He3 particle.

@victor-gonzalez
Copy link
Collaborator

Probably this is going to affect the FemtoDream datamodel
@blacwovie Please, set it as draft while you agree on it with the FemtoDream people @ariedel-cern @lauraser @sartozza

blacwovie added a commit to blacwovie/O2Physics that referenced this pull request Oct 23, 2024
Please consider the following formatting changes to AliceO2Group#8109
blacwovie added a commit to blacwovie/O2Physics that referenced this pull request Oct 23, 2024
blacwovie added a commit to blacwovie/O2Physics that referenced this pull request Oct 23, 2024
Revert "Please consider the following formatting changes to AliceO2Group#8109"
blacwovie added a commit to blacwovie/O2Physics that referenced this pull request Oct 23, 2024
Please consider the following formatting changes to AliceO2Group#8109
@ariedel-cern
Copy link
Collaborator

Hi @blacwovie,
copying and creating a new producer task is not the way to go to add He3 PID.
I went ahead and created another draft to extend the data model to include the PID for He3 and triton. The PR is not quite finished yet because to see the PID, I also need to add a histogram to the debug task.

@victor-gonzalez : He3 and trition have not been in the data model so far because there was no analysis yet and the PID task did not have the autoconfigre feature back then. The changes are rather straight forward, but if you could also have a short look at the draft, that would be nice.

Draft #8123

@blacwovie
Copy link
Author

Hi,@ariedel-cern So sorry for causing troubles,I really didn't think this through. May I ask when will the new draft with He3 complete? And is it possible to add histogram of particles dE/dx in the task?

@ariedel-cern
Copy link
Collaborator

Hi, I should be done with the draft today or tomorrow. And we should be able to get it merged soon after. A histogram for the energy loss is already implemented. Only a histogram with the nsigma distribution for the triton/He3 PID was missing from the debug task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants