Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unneeded regex #13851

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Drop unneeded regex #13851

merged 2 commits into from
Jan 10, 2025

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 10, 2025

This pollutes a bunch of compile units with unneeded code for creating and handling
the regex.

@ktf ktf requested a review from a team as a code owner January 10, 2025 12:35
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf
Copy link
Member Author

ktf commented Jan 10, 2025

This gets scattered on a gazillion of places and actually significantly affects O2 compilation.

This pollutes a bunch of compile units with unneeded code for creating and handling
the regex.
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for d35d38c at 2025-01-10 15:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
input_line_9:1051:14: error: no template named 'bitset' in namespace 'std'
input_line_9:1056:14: error: no template named 'bitset' in namespace 'std'
input_line_9:1061:14: error: no template named 'bitset' in namespace 'std'
input_line_9:1085:19: error: no member named 'bitset' in namespace 'std'
input_line_9:1085:36: error: expected member name or ';' after declaration specifiers
input_line_9:1086:8: error: no template named 'bitset' in namespace 'std'
input_line_9:1089:8: error: no template named 'bitset' in namespace 'std'
input_line_9:1090:8: error: no template named 'bitset' in namespace 'std'
input_line_9:1093:8: error: no template named 'bitset' in namespace 'std'
input_line_9:1094:8: error: no template named 'bitset' in namespace 'std'
Error: /sw/slc8_x86-64/ROOT/v6-32-06-alice1-27/bin/rootcling: compilation failure (/sw/BUILD/0c84f7b5b820902deb0711a61850bf5700585125/O2/Detectors/ZDC/calib/G__O2ZDCCalib09a588d870_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf merged commit fff0296 into AliceO2Group:dev Jan 10, 2025
10 of 11 checks passed
@ktf
Copy link
Member Author

ktf commented Jan 13, 2025

For the record, this resulted in 350 MB (yes 1 000 000 bytes) smaller installation size, AFAICT. More changes could have affected that as well, actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants