Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: refactor ConfigParamRegistry to use C++20 #13850

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 10, 2025

Use constraints to make sure we can out-of-line known
types of parameter.

Remove the need to include Array2D.h when not used.

Reduce dependence on ptree, in particular moving the helper methods
out of line.

@ktf ktf requested a review from a team as a code owner January 10, 2025 10:23
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 48757bd at 2025-01-10 13:36:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for c4a029d at 2025-01-10 14:58:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13850-slc8_x86-64/0/Framework/Core/include/Framework/ConfigParamRegistry.h:96:44: error: cannot convert 'boost::property_tree::basic_ptree<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' to 'long long int' in initialization
ninja: build stopped: subcommand failed.

Full log here.

Use constraints to make sure we can out-of-line known
types of parameter.

Remove the need to include Array2D.h when not used.

Reduce dependence on ptree, in particular moving the helper methods
out of line.
@ktf
Copy link
Member Author

ktf commented Jan 11, 2025

macOS tested separately. Merging.

@ktf ktf merged commit a6d96bc into AliceO2Group:dev Jan 11, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants