Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk TPM output to scpca-nf #816

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Add bulk TPM output to scpca-nf #816

merged 3 commits into from
Jan 29, 2025

Conversation

jashapiro
Copy link
Member

Closes #815

I was looking at scpca-nf, and realized that the changes to add TPM output were quite minimal, so I went ahead and did that. I left the count file name unchanged, despite its ambiguity, and simply added one more output file, in the same directory.

Since the script name seemed a bit out of date, I modified that as well.

@jashapiro jashapiro requested a review from sjspielman January 29, 2025 18:33
Copy link
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun surprise, looks good!

I approved, but we should update this sentence too:

If bulk libraries were processed, a `bulk_quant.tsv` and `bulk_metadata.tsv` summarizing the counts data and metadata across all libraries will also be present in the `results` directory.

I guess we'll need some scpca-docs issues as well, but this won't make it to the portal for a little bit I imagine.

@jashapiro
Copy link
Member Author

Fun surprise, looks good!

I approved, but we should update this sentence too:

If bulk libraries were processed, a `bulk_quant.tsv` and `bulk_metadata.tsv` summarizing the counts data and metadata across all libraries will also be present in the `results` directory.

I guess we'll need some scpca-docs issues as well, but this won't make it to the portal for a little bit I imagine.

Turns out that document is a bit out of date... we probably want an issue to update it as well.

@jashapiro jashapiro merged commit ca9e7b4 into development Jan 29, 2025
4 checks passed
@jashapiro jashapiro deleted the jashapiro/tpm-out branch January 29, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants