Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taylormadeapps
Copy link

Fixes issue: #77 for me. Submitting for review

Fixes issue: AlJohri#77 for me. Submitting for review
@AlJohri
Copy link
Owner

AlJohri commented Apr 28, 2023

Glad you figured it out! Do you know if this will break for previous versions of Word? Any links to documentation about the difference between these two functions?

@taylormadeapps
Copy link
Author

taylormadeapps commented Apr 28, 2023

Hmm, good point. I didn't think about regression. I'm wondering if we should do a check for the existence of the saveas2 function and if it doesn't exist then fallback to saveas.

Looking at something like use_old_save_method=hasattr(Dynamo, "saveAs2") and callable(getattr(Dynamo, "saveAs2"))
but given that it's win32com.client - not obvious what the class name for document is.

Maybe a try and except might do the job. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants