Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-read from user's configuration so no variables are required on deploy #32

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

araghukas
Copy link

Changed

  • Read id's from user's config instead of input (no more required args)
  • Update executor config output, remove unused
  • Make owners var optional
  • Conform to 'alphanumeric chars only' rule for resource names
  • Use templatefile instead of template_file (MacOS compatibility)

incorporates PRs:
#29
#27

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (656b8aa) 100.00% compared to head (dde77b8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          271       271           
=========================================
  Hits           271       271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant