Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix for azure batch plugin #28

Closed
wants to merge 1 commit into from
Closed

Conversation

mpvgithub
Copy link
Contributor

Fix

  • Added subscription_id & owners to ExecutorInfraDefaults to accept arguments from deploy command

Changed

  • Modified the owners variable to have a default value

@mpvgithub mpvgithub self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9737d13) 100.00% compared to head (cbd19c1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          264       266    +2     
=========================================
+ Hits           264       266    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kessler-frost
Copy link
Member

@mpvgithub I'm importing these changes to a different PR: #30.

@araghukas
Copy link

no longer required after #32

@araghukas araghukas closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants