Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some training fixes and improvements #65

Merged
merged 25 commits into from
Apr 22, 2024
Merged

Some training fixes and improvements #65

merged 25 commits into from
Apr 22, 2024

Conversation

C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Mar 5, 2024

  • More reliable WandB starting/stopping
  • Ensuring csv saving occurs properly even when worker is stopped
  • Additional documentation for WNet
  • Fix pretrained weights loading
  • More flexible WNet3D parameters

  • Switch logger to INFO before merging

@C-Achard C-Achard added enhancement New feature or request fix Something needs to be or has been fixed ML Related to machine learning : MONAI, Torch... labels Mar 5, 2024
@C-Achard C-Achard self-assigned this Mar 5, 2024
@C-Achard C-Achard marked this pull request as ready for review March 21, 2024 14:53
@C-Achard C-Achard requested a review from CYHSM March 21, 2024 14:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 80.50%. Comparing base (9dd5b39) to head (c22d2a6).

Files Patch % Lines
...ri_cellseg3d/code_plugins/plugin_model_training.py 12.00% 22 Missing ⚠️
napari_cellseg3d/code_models/worker_training.py 11.11% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   80.80%   80.50%   -0.31%     
==========================================
  Files          46       46              
  Lines        6096     6120      +24     
==========================================
+ Hits         4926     4927       +1     
- Misses       1170     1193      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@C-Achard C-Achard force-pushed the cy/training-fixes branch from 0522a75 to c22d2a6 Compare April 2, 2024 09:46
@MMathisLab
Copy link
Member

small bump for @CYHSM to review 🥳

Copy link
Member

@MMathisLab MMathisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but did not run code

@C-Achard C-Achard merged commit c98d734 into main Apr 22, 2024
4 checks passed
@MMathisLab MMathisLab deleted the cy/training-fixes branch April 30, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix Something needs to be or has been fixed ML Related to machine learning : MONAI, Torch...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants