forked from AdaGold/media-ranker-revisited
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ana Lisa Sutherland: Octos C9: MediaRanker-Revisited #31
Open
The-Beez-Kneez
wants to merge
17
commits into
Ada-C9:master
Choose a base branch
from
The-Beez-Kneez:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5c8b36d
Have working tests for the def root method in Works Controller
The-Beez-Kneez d5e5551
Have working tests for index method in Works Controller, basically co…
The-Beez-Kneez 8a5e08c
Have test working for new method in Works Controller, modeled after l…
The-Beez-Kneez 2ca8add
Think I have all the create tests made and passing, still would like …
The-Beez-Kneez 070014e
Created show method tests in work controller, all passing and testing…
The-Beez-Kneez 46e092e
Added in Edit Method tests in Work Controller, followed same layout f…
The-Beez-Kneez 9c39792
Finished Passing tests for Update Method in Works Controller, also fi…
The-Beez-Kneez df7fb7e
Completed passing tests for destroy method tests in Works Controller.
The-Beez-Kneez 693f77a
Finished passing tests for Upvote method in Works Controller.
The-Beez-Kneez 57505f9
Added in index method tests for User Controller
The-Beez-Kneez e6a732d
Accidentally made changes before I merged branches
The-Beez-Kneez a8dc582
Merge branch 'user_index_tests'
The-Beez-Kneez 9513238
Added in tests for show method in User Controller
The-Beez-Kneez c697371
Made upvote tests more robust, added another to check that a logged i…
The-Beez-Kneez b558f51
Created login tests to test user login
The-Beez-Kneez f82a15f
Added in tests for logout.
The-Beez-Kneez 99ea2f2
Added in OmniAuth Github login, updated session controller to reflect…
The-Beez-Kneez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,6 @@ | |
|
||
# Ignore Byebug command history file. | ||
.byebug_history | ||
|
||
# Ignore .env files, so that it is never put on Git | ||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,2 @@ | ||
class User < ApplicationRecord | ||
has_many :votes | ||
has_many :ranked_works, through: :votes, source: :work | ||
|
||
validates :username, uniqueness: true, presence: true | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
class CreateUsers < ActiveRecord::Migration[5.0] | ||
def change | ||
create_table :users do |t| | ||
t.string :name | ||
t.string :email | ||
t.integer :uid, null: false # this is the identifier provided by GitHub | ||
t.string :provider, null: false # this tells us who provided the identifier | ||
|
||
t.timestamps | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project already has a table
users
, so creating a new table probably isn't what you want here. Instead you might edit the existing table usingadd_column
.Looks like Rails takes the last one if there are multiple migrations with the same name, so this may have worked accidentally.