Ana Lisa Sutherland: Octos C9: MediaRanker-Revisited #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pied the same ones used for roots
…ibrary example in class
…clarification on why one is working
… for correct thing.
…or Show Method. Also added in .env file to begun OmniAuth procedure
…xed bug in Works Controller changed render :not_found to :bad_request
…n user/vote pair registers a vote via user as well as work
… this, updated application view to support this.
MediaRanker RevistedWhat We're Looking For
|
droberts-sea
reviewed
May 5, 2018
| create_table :users do |t| | ||
| t.string :name | ||
| t.string :email | ||
| t.integer :uid, null: false # this is the identifier provided by GitHub |
There was a problem hiding this comment.
This project already has a table users, so creating a new table probably isn't what you want here. Instead you might edit the existing table using add_column.
Looks like Rails takes the last one if there are multiple migrations with the same name, so this may have worked accidentally.
| it "succeeds with one media type absent" do | ||
| # Precondition: there is at least one media in two of the categories | ||
| %w(albums movies).each do |category| | ||
| Work.by_category(category).length.must_be :>,0 | ||
| Work.by_category(:books).destroy_all |
There was a problem hiding this comment.
This is strange to me - inside the loop you're both checking that the category has members and destroying all the books. Probably the destroy_all wants to be outside the loop.
| end | ||
|
|
||
| it "redirects to the work page after the user has logged out" do | ||
| work_id = Work.first.id | ||
|
|
There was a problem hiding this comment.
Why is this test nested under upvote?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tests are all broken and some commented out (when I was attempting to hunt down what went wrong). Will fix later today.