Skip to content

branches- vi #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

branches- vi #40

wants to merge 6 commits into from

Conversation

criacuervos
Copy link

JS Adagrams

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? my knowledge of looping, of if statements, and ternary statements!
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? yea, i would browse the MDN webdocs for javascript
What was a challenge you were able to overcome on this assignment? i definitely ran into some issues with syntax, and how to implement the js versions of things i knew in ruby
What has been interesting and positive about learning a new programming language? learning about the possibilities for refactoring in ways you wouldnt have known through googling and asking friends is really amazing
What is something to focus on your learnings in JavaScript in the next week? honing in on understanding syntax a bit better; where there are semicolons, and why. also understanding the scope of variable references in js

@jmaddox19
Copy link

JS Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions x
Small commits with meaningful commit messages yes, but only after completing the first 2 waves. Those two could've been broken up into at least 2 commits.
Code Requirements
drawLetters method x
Uses appropriate data structure to store the letter distribution x
All tests for drawLetters pass x
usesAvailableLetters method x
All tests for usesAvailableLetters pass x
scoreWord method x
Uses appropriate data structure to store the letter scores x
All tests for scoreWord pass x
Optional
highestScoreFrom method o
Appropriately handles edge cases for tie-breaking logic o
All tests for highestScoreFrom pass o
Overall Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants