Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3.1 #1635

Merged
merged 17 commits into from
Aug 30, 2024
Merged

7.3.1 #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2fc57dc
#1627: run publish journey action sequentially for multi-step journey…
JoernBerkefeld Aug 29, 2024
bc60650
#1627: improve error handling for publish
JoernBerkefeld Aug 29, 2024
cf25fa7
#1627: add spinner to publish journey
JoernBerkefeld Aug 29, 2024
eb093bb
#1627: fix publish journey tests
JoernBerkefeld Aug 29, 2024
d802d95
#1627: improve logs & tests
JoernBerkefeld Aug 29, 2024
5da1153
Merge pull request #1629 from Accenture/bug/1627-publishing-multiple-…
JoernBerkefeld Aug 29, 2024
ed13296
#1631: ensure Common fields are tracked but originals are kept on Con…
JoernBerkefeld Aug 29, 2024
94f62a6
#1631: correct common-vs-contact logic and fix check of ca.contactKey…
JoernBerkefeld Aug 29, 2024
7c63142
#1631: checks on passThroughArgument, primaryObjectFilterCriteria, re…
JoernBerkefeld Aug 29, 2024
ec7cacf
Revert "#1570: disable beautyAmp for *.html files again"
JoernBerkefeld Aug 30, 2024
fef681d
#0: fix predeploy check of sf entry events in journeys
JoernBerkefeld Aug 30, 2024
0fc5335
Merge pull request #1632 from Accenture/task/1631-improve-common-vs-c…
JoernBerkefeld Aug 30, 2024
7c70597
#1510: ensure we always cache default roles & timezones (relevant for…
JoernBerkefeld Aug 30, 2024
e03c52a
Merge pull request #1634 from Accenture/bug/1510-cant-retrieve-user-a…
JoernBerkefeld Aug 30, 2024
281b77e
#0: improved release process by introducing new prepare-release task
JoernBerkefeld Aug 30, 2024
1493c34
prepare-release changes
JoernBerkefeld Aug 30, 2024
cb0c778
update note on what prepare-release does
JoernBerkefeld Aug 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE/pr_template_release.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
### Before merge

- [ ] Wiki updated with info in ticket listed under **Documentation**
- [ ] ran `npm audit fix`
- [ ] ran `npm run lint-ts`
- [ ] ran `npm run lint:fix`
- [ ] ran `npm run prepare-release` (which runs `npm audit fix`, `npm run lint-ts`, `npm run lint:fix`, `git add`, `git commit`)
- [ ] pushed potential changes made by prepare-release

### After merge

Expand Down
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"sql-formatter.indent": " ",
"sql-formatter.uppercase": true,
"[html]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.defaultFormatter": "FiB.beautyAmp"
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
Expand Down
7 changes: 7 additions & 0 deletions @types/lib/metadataTypes/Event.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Event.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion @types/lib/metadataTypes/Journey.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Journey.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions @types/lib/metadataTypes/Role.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Role.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions boilerplate/files/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
},
"editor.formatOnSave": true,
"files.associations": {
"*.ssjs": "javascript"
"*.ssjs": "javascript",
"*.html": "ampscript"
},
"files.eol": "\n",
"files.exclude": {
Expand All @@ -48,7 +49,7 @@
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[html]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.defaultFormatter": "FiB.beautyAmp"
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
Expand Down
4 changes: 4 additions & 0 deletions boilerplate/forcedUpdates.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
[
{
"version": "7.3.1",
"files": [".vscode/settings.json"]
},
{
"version": "7.3.0",
"files": [".vscode/settings.json"]
Expand Down
Loading
Loading