Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.3.1 #1635

Merged
merged 17 commits into from
Aug 30, 2024
Merged

7.3.1 #1635

merged 17 commits into from
Aug 30, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 30, 2024 •
edited
Loading

…s to fix race condition for sf-journeys# Release details

Checklist

Before merge

  • Wiki updated with info in ticket listed under Documentation
  • ran npm run prepare-release (which runs npm audit fix, npm run lint-ts, npm run lint:fix, git add, git commit)
  • pushed potential changes made by prepare-release

After merge

  • merged all dependabot PRs that target main branch
  • updated bug template to include the new version
  • updated .mcdevrc for tests to the new version
  • ran npm run version:major/minor/patch
  • pushed version-prep commits
  • merged main branch into develop branch
  • closed GitHub milestone
  • created new GitHub Release

Documentation

... insert updated documentation here ...

Issues

JoernBerkefeld and others added 14 commits August 29, 2024 18:07
@JoernBerkefeld
#1627: run publish journey action sequentially for multi-step journey…
2fc57dc 
…s to fix race condition for sf-journeys
@JoernBerkefeld
#1627: improve error handling for publish
bc60650
@JoernBerkefeld
#1627: add spinner to publish journey
cf25fa7
@JoernBerkefeld
#1627: fix publish journey tests
eb093bb
@JoernBerkefeld
#1627: improve logs & tests
d802d95
@JoernBerkefeld
Merge pull request #1629 from Accenture/bug/1627-publishing-multiple-…
5da1153 
…sf-triggered-journeys-in-parallel-causes-error

bug/1627 run publish journey action sequentially for multi-step journeys to fix race condition for sf-journeys
@JoernBerkefeld
#1631: ensure Common fields are tracked but originals are kept on Con…
ed13296 
…tact/Lead
@JoernBerkefeld
#1631: correct common-vs-contact logic and fix check of ca.contactKey…
94f62a6 
… logic
@JoernBerkefeld
#1631: checks on passThroughArgument, primaryObjectFilterCriteria, re…
7c63142 
…latedObjectFilterCriteria
@JoernBerkefeld
Revert "#1570: disable beautyAmp for *.html files again"
ec7cacf 
This reverts commit 0e7a251.

html formatting totally ruined ampscript after this change
@JoernBerkefeld
#0: fix predeploy check of sf entry events in journeys
fef681d
@JoernBerkefeld
Merge pull request #1632 from Accenture/task/1631-improve-common-vs-c…
0fc5335 
…ontact-checks-for-salesforce-data-entry-events

Task/1631 improve configurationArgument checks incl common vs contact logic for salesforce data entry events
@JoernBerkefeld
#1510: ensure we always cache default roles & timezones (relevant for…
7c70597 
… retrieve-user)
@JoernBerkefeld
Merge pull request #1634 from Accenture/bug/1510-cant-retrieve-user-a…
e03c52a 
…nd-role-in-one-command

bug/1510 fix retrieving users and roles together failing due to missing timezones
@JoernBerkefeld JoernBerkefeld added this to the 7.3.1 milestone Aug 30, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

Coverage Report

Commit:cb0c778
Base: main@5e97ce7

Type Base This PR
Total Statements Coverage  70.15%  70.09%  (-0.06%)
Total Branches Coverage  68.95%  68.85%  (-0.1%)
Total Functions Coverage  82.21%  82.11%  (-0.1%)
Total Lines Coverage  70.15%  70.09%  (-0.06%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit cba384d into main Aug 30, 2024
14 checks passed
@JoernBerkefeld JoernBerkefeld changed the title #1627: run publish journey action sequentially for multi-step journey… 7.3.1 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
None yet
Projects
None yet
Milestone
7.3.1
1 participant
@JoernBerkefeld