Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/934: handle authentication errors during mcdev join gracefully #1047

Merged
merged 1 commit into from
Jul 24, 2023
Merged

bugfix/934: handle authentication errors during mcdev join gracefully #1047

merged 1 commit into from
Jul 24, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jul 24, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

image

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jul 24, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 24, 2023
@JoernBerkefeld JoernBerkefeld changed the title #934: handle authentication errors during mcdev join gracefully bugfix/934: handle authentication errors during mcdev join gracefully Jul 24, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 24, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Jul 24, 2023 that may be closed by this pull request
[BUG] issues with git clone not handled in mcdev join #934
Closed
2 tasks
@JoernBerkefeld JoernBerkefeld added the e/IDE EPIC label Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

Coverage Report

Commit:17d5503
Base: develop@1cb3771

Type Base This PR
Total Statements Coverage  51.76%  51.73%  (-0.03%)
Total Branches Coverage  41.62%  41.6%  (-0.02%)
Total Functions Coverage  60.18%  60.18%  (+0%)
Total Lines Coverage  51.67%  51.64%  (-0.03%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 27b3134 into develop Jul 24, 2023
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/934-issues-with-git-clone-not-handled-in-mcdev-join branch July 24, 2023 14:35
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/IDE EPIC
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

[BUG] issues with git clone not handled in mcdev join
1 participant
@JoernBerkefeld