Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] issues with git clone not handled in mcdev join #934

Closed
2 tasks done
JoernBerkefeld opened this issue May 25, 2023 · 1 comment · Fixed by #1047 or #1023
Closed
2 tasks done

[BUG] issues with git clone not handled in mcdev join #934

JoernBerkefeld opened this issue May 25, 2023 · 1 comment · Fixed by #1047 or #1023
Assignees
@JoernBerkefeld
Labels
bug Something isn't working e/IDE EPIC
Milestone
5.2.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image
it seems the script simply skips to the next step when git clone fails and hence tries to switch the working directory to the repo's name.

Expected Behavior

we should catch the error and output our own when git clone fails.

Steps To Reproduce

  1. run mcdev join
  2. answer Yes to having the git repo url
  3. paste an invalid repo URL
  4. See error...

Version

5.0.1

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/IDE EPIC labels May 25, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.1.0 milestone May 25, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.1.0, 5.2.0 Jun 5, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.2.0, 5.3.0 Jun 29, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 24, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.3.0, 5.2.0 Jul 24, 2023
JoernBerkefeld added a commit that referenced this issue Jul 24, 2023
@JoernBerkefeld
#934: handle authentication errors during mcdev join gracefully
17d5503
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 24, 2023
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 24, 2023 that will close this issue
bugfix/934: handle authentication errors during mcdev join gracefully #1047
Merged
4 tasks
@github-actions
Copy link

Closed by #1047.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/IDE EPIC
Projects
None yet
Milestone
5.2.0
1 participant
@JoernBerkefeld