Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Update requirements #567

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Update requirements #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
aiomultiprocess==0.9.0
black==23.9.1
datasets==2.18.0
gitpython==3.1.41
fire==0.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to see fire moved to dev-requirements.txt as it suggests it's not needed for the production environment. However, it would be beneficial to include a brief explanation in the PR description about why certain dependencies were moved to dev-requirements.txt. This helps in understanding the rationale behind such changes, especially for dependencies that might not be obviously development-only.

isort==5.12.0
pip-licenses==4.3.3
plotly==5.18.0
pyright==1.1.358
pytest-xdist==3.3.1
pytest==7.4.0
pytest-asyncio==0.21.1
pytest-mock==3.11.1
pytest-reportlog==0.4.0
pytest-timeout==2.2.0
python-dotenv==1.0.0
ruff==0.0.292
tiktoken==0.6.0
13 changes: 2 additions & 11 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
attrs==23.1.0
attrs>=23.1.0
backoff==2.2.1
chromadb==0.4.24
fire==0.5.0
gitpython==3.1.41
httpx==0.25.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of chromadb==0.4.24 is mentioned in the PR description, but there's no mention of chromadb being used by ragdaemon now. It might be helpful to clarify this dependency change in the PR description for better understanding of the dependency graph and to ensure that all necessary dependencies are correctly managed.

jinja2==3.1.3
jsonschema>=4.17.0
numpy==1.26.0
numpy>=1.22.0
openai==1.13.3
pillow==10.1.0
prompt-toolkit==3.0.39
Pygments==2.15.1
pytest==7.4.0
pytest-asyncio==0.21.1
pytest-mock==3.11.1
pytest-reportlog==0.4.0
pytest-timeout==2.2.0
python-dotenv==1.0.0
ragdaemon~=0.1.0
selenium==4.15.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since numpy and attrs versions have been changed from fixed to minimum versions, it's important to ensure that the application is tested across different versions of these libraries to avoid potential incompatibilities. Consider adding a note about testing done or to be done to verify compatibility across the newly allowed versions.

sentry-sdk==1.34.0
Expand All @@ -26,7 +18,6 @@ spiceai~=0.1.0
termcolor==2.3.0
textual==0.47.1
textual-autocomplete==2.1.0b0
tiktoken==0.6.0
typing_extensions==4.8.0
tqdm>=4.66.1
webdriver_manager==4.0.1
Expand Down
Loading