-
Notifications
You must be signed in to change notification settings - Fork 243
Conversation
Numpy and attrs no longer pinned to exact versions. Chroma removed (used by ragdaemon now) pytest and fire dependencies moved to dev-requirements
backoff==2.2.1 | ||
chromadb==0.4.24 | ||
fire==0.5.0 | ||
gitpython==3.1.41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of chromadb==0.4.24
is mentioned in the PR description, but there's no mention of chromadb
being used by ragdaemon
now. It might be helpful to clarify this dependency change in the PR description for better understanding of the dependency graph and to ensure that all necessary dependencies are correctly managed.
@@ -1,10 +1,17 @@ | |||
aiomultiprocess==0.9.0 | |||
black==23.9.1 | |||
datasets==2.18.0 | |||
gitpython==3.1.41 | |||
fire==0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see fire
moved to dev-requirements.txt
as it suggests it's not needed for the production environment. However, it would be beneficial to include a brief explanation in the PR description about why certain dependencies were moved to dev-requirements.txt
. This helps in understanding the rationale behind such changes, especially for dependencies that might not be obviously development-only.
pytest-mock==3.11.1 | ||
pytest-reportlog==0.4.0 | ||
pytest-timeout==2.2.0 | ||
python-dotenv==1.0.0 | ||
ragdaemon~=0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since numpy
and attrs
versions have been changed from fixed to minimum versions, it's important to ensure that the application is tested across different versions of these libraries to avoid potential incompatibilities. Consider adding a note about testing done or to be done to verify compatibility across the newly allowed versions.
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. This PR makes several dependency management changes, including moving some dependencies to |
Numpy and attrs no longer pinned to exact versions. Chroma removed (used by ragdaemon now)
pytest and fire dependencies moved to dev-requirements
Pull Request Checklist