[feature]: Add images to the game #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the work! |
|
@Aatmaj-Zephyr are those screenshots enough? Should I add anything else? |
|
Thanks |
This was referenced Oct 10, 2022
jma26
added a commit
to jma26/Basic-memory-game
that referenced
this pull request
Oct 12, 2022
jma26
added a commit
to jma26/Basic-memory-game
that referenced
this pull request
Oct 12, 2022
jma26
added a commit
to jma26/Basic-memory-game
that referenced
this pull request
Oct 12, 2022
jma26
added a commit
to jma26/Basic-memory-game
that referenced
this pull request
Oct 12, 2022
jma26
added a commit
to jma26/Basic-memory-game
that referenced
this pull request
Oct 12, 2022
Aatmaj-Zephyr
pushed a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so instead of just letters, it shows 16 cards from a collection of images, some styling was modified as well to have a better presentation of such images. This new functionality can be extended by creating different themes for the game, adding replay value.
The images are smash bros related, because it was the first thing I thought of.
Related PRs and Issues
This solves issue #75
Screenshots of changes made to the webapp.
Have you updated the README.md file?
Have you made any big breakthrough change?
Is the code beautified?
Is the code clear to understand with proper variable naming and comments?