Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing images issue #81 #89

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

jma26
Copy link
Contributor

@jma26 jma26 commented Oct 12, 2022

What does this PR do?

After thoroughly looking into the reverted code. There was a minor annoyance in how Github pages reads nested folders, images through the current directory and requires us to put a period, "./" before the slash. This fixed the disappearing images when live.

Additional changes in addition to the images

  • Minor bug with the randomized numbers generated from 1-16 (numbers between the 1st image and 16th image). Had to add a +1 so it would randomly select between 1-16 instead of 0-15.
  • Minor update disabling the image from being clicked with pointer-events set to none instead of using the attribute "disable" on it like a button before

Issue references #81 and #88

@Aatmaj-Zephyr Aatmaj-Zephyr merged commit fb57d92 into Aatmaj-Zephyr:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants