Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firoozh/bug and clean #11

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Firoozh/bug and clean #11

merged 6 commits into from
Mar 14, 2024

Conversation

hsnfirooz
Copy link
Member

Fixing open issues:

In addition, added support for the following:

  • Checking a valid aalto email
  • Better logging for GPU hardware failure
  • Better error logging as WhisperX was complaining for the language setting

@ruokolt
Copy link
Contributor

ruokolt commented Mar 13, 2024

Looks good!

I suggested a modification to subprocess.run exception handling: catch subprocess.CalledProcessError instead of Exception (but backoff to Exception anyways).

Also ran linting (black + isort).

Copy link
Member Author

@hsnfirooz hsnfirooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's defiantly better this way. Thanks for the suggestion.

@ruokolt ruokolt merged commit 5066e95 into main Mar 14, 2024
2 checks passed
@ruokolt ruokolt deleted the firoozh/bug-and-clean branch March 14, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants