Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #4

Closed
ruokolt opened this issue Jan 30, 2024 · 1 comment
Closed

Add type hints #4

ruokolt opened this issue Jan 30, 2024 · 1 comment

Comments

@ruokolt
Copy link
Contributor

ruokolt commented Jan 30, 2024

Type hints were added to some parts of the code base in #2.

Add type hints to whole code base for consistency.
@hsnfirooz hsnfirooz mentioned this issue Mar 8, 2024
Merged
@hsnfirooz
Copy link
Member

This issue has been address in #11.

ruokolt added a commit that referenced this issue Mar 14, 2024
@hsnfirooz @ruokolt
Firoozh/bug and clean (#11)
5066e95 
Fix open issues:

- Add type hints #4
- Folder path including non audio files #6
- Model selector #7
- Error logging #10

In addition, add support for the following:

- Checking a valid aalto email
- Better logging for GPU hardware failure
- Better error logging as WhisperX was complaining for the language setting

---------

Co-authored-by: Hossein Firooz <[email protected]>
Co-authored-by: Teemu Ruokolainen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsnfirooz @ruokolt