Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch kk filter by status #66

Merged

Conversation

Ko-Khan
Copy link
Collaborator

@Ko-Khan Ko-Khan commented Mar 28, 2024

  • Add new command set -a
  • With this new command, user can now set up a filter based on status of an article.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 8.51064% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 54.28%. Comparing base (ca9335b) to head (1afa057).
Report is 14 commits behind head on master.

Files Patch % Lines
...s/model/article/ArticleMatchesStatusPredicate.java 0.00% 17 Missing ⚠️
...ic/commands/articlecommands/SetArticleCommand.java 0.00% 10 Missing ⚠️
.../address/logic/parser/SetArticleCommandParser.java 0.00% 7 Missing ⚠️
...c/main/java/seedu/address/model/ArticleFilter.java 50.00% 3 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 33.33% 2 Missing ⚠️
...del/article/exceptions/InvalidStatusException.java 0.00% 2 Missing ⚠️
.../java/seedu/address/logic/commands/SetCommand.java 0.00% 1 Missing ⚠️
.../seedu/address/logic/parser/ArticleBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
- Coverage     55.38%   54.28%   -1.10%     
- Complexity      451      452       +1     
============================================
  Files            97      103       +6     
  Lines          1959     2006      +47     
  Branches        200      205       +5     
============================================
+ Hits           1085     1089       +4     
- Misses          835      878      +43     
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ko-Khan Ko-Khan self-assigned this Mar 28, 2024
@Ko-Khan Ko-Khan linked an issue Mar 28, 2024 that may be closed by this pull request
Copy link
Collaborator

@Murugan-Maniish Murugan-Maniish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, nothing looks off.

/**
* Sets predicates that filter article book
*/
public class SetCommand {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "FilterCommand"

Copy link
Collaborator Author

@Ko-Khan Ko-Khan Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to emphasize that using the command sets the filter for all future searches.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ko-Khan Ko-Khan added enhancement New feature or request priority.High Must do labels Mar 28, 2024
@bennyLCK bennyLCK added this to the v1.3b milestone Mar 28, 2024
@Ko-Khan Ko-Khan merged commit e2469aa into AY2324S2-CS2103T-F12-2:master Mar 30, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority.High Must do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a experienced user, I can filter articles by their status
3 participants