-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch kk filter by status #66
Branch kk filter by status #66
Conversation
Ko-Khan
commented
Mar 28, 2024
- Add new command set -a
- With this new command, user can now set up a filter based on status of an article.
Add ArticleMatchesStatusPredicate class. Add exception for invalid statuses.
SetArticleCommandParser
new method getFilter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
============================================
- Coverage 55.38% 54.28% -1.10%
- Complexity 451 452 +1
============================================
Files 97 103 +6
Lines 1959 2006 +47
Branches 200 205 +5
============================================
+ Hits 1085 1089 +4
- Misses 835 878 +43
Partials 39 39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, nothing looks off.
/** | ||
* Sets predicates that filter article book | ||
*/ | ||
public class SetCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not "FilterCommand"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to emphasize that using the command sets the filter for all future searches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM