Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch kk filter articles by date #70

Merged

Conversation

Ko-Khan
Copy link
Collaborator

@Ko-Khan Ko-Khan commented Mar 28, 2024

Add ability to filter by date.

Command format is set -a S/DRAFT ST/ EN/

@Ko-Khan Ko-Khan added this to the v1.3 milestone Mar 28, 2024
@Ko-Khan Ko-Khan linked an issue Mar 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 8.82353% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 51.24%. Comparing base (ca9335b) to head (072e5d7).
Report is 14 commits behind head on master.

Files Patch % Lines
...ic/commands/articlecommands/SetArticleCommand.java 0.00% 17 Missing ⚠️
...s/model/article/ArticleMatchesStatusPredicate.java 0.00% 17 Missing ⚠️
.../address/logic/parser/SetArticleCommandParser.java 0.00% 9 Missing ⚠️
...del/article/ArticleMatchesTimePeriodPredicate.java 0.00% 8 Missing ⚠️
...c/main/java/seedu/address/model/ArticleFilter.java 50.00% 3 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 33.33% 2 Missing ⚠️
...odel/article/exceptions/InvalidDatesException.java 0.00% 2 Missing ⚠️
...del/article/exceptions/InvalidStatusException.java 0.00% 2 Missing ⚠️
.../java/seedu/address/logic/commands/SetCommand.java 0.00% 1 Missing ⚠️
.../seedu/address/logic/parser/ArticleBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     55.38%   51.24%   -4.15%     
- Complexity      451      452       +1     
============================================
  Files            97      109      +12     
  Lines          1959     2129     +170     
  Branches        200      222      +22     
============================================
+ Hits           1085     1091       +6     
- Misses          835      999     +164     
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Murugan-Maniish Murugan-Maniish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seem to have a lot of overlap with #66, I'm not sure whether order of merging will be relevant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right to assume this PR should be merged before #66 since the command wouldn't work without the this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think filter by status should be merged first. This is an extension of that pr.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job fixing the comments

@Ko-Khan Ko-Khan added enhancement New feature or request priority.High Must do labels Mar 28, 2024
@bennyLCK bennyLCK modified the milestones: v1.3, v1.3b Mar 28, 2024
@Ko-Khan Ko-Khan self-assigned this Mar 29, 2024
@Ko-Khan Ko-Khan merged commit c3e43e2 into AY2324S2-CS2103T-F12-2:master Mar 30, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority.High Must do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an intermediate user, I can filter articles by publication date.
3 participants