Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoadFromBag assumptions causing C++ exceptions during serialization (backport #438) #470

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from
Open

Fix LoadFromBag assumptions causing C++ exceptions during serialization (backport #438) #470

wants to merge 1 commit into from

Commits on Jul 29, 2024

  1. Fix LoadFromBag assumptions causing C++ exceptions during serializati… 

    …on (#438)

Fix LoadFromBag assumptions

* Not all bags have only GridMap messages
* Not all bags have GridMap on the right topic
* Add test for trying to load a grid map from a bag that doesn't
  contain it on the expected topic
* Add nullptr check on reader messages
* Remove unused include
* Don't skip reporting when tests fail

(cherry picked from commit 25a1ea5)
    @Ryanf55 @mergify
    Ryanf55 authored and mergify[bot] committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    27cff71 View commit details
    Browse the repository at this point in the history