Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to TreeMaker logic to handle new MC waveforms #329

Open
wants to merge 2 commits into
base: Application
Choose a base branch
from

Conversation

S81D
Copy link
Contributor

@S81D S81D commented Jan 6, 2025

Describe your changes

This PR is dependent on Andrew's new PMTWaveformSim tool (#324). His new tool generates waveforms from MC hits and runs the data hit finding tool (PhaseIIADCHitFinder) over the MC waveforms. Those hits are saved in the same pulse vector as the data hits. The logic of the PhaseIITreeMaker needed to be changed to handle data-like hits for MC events. Essentially just added some if / else statements to make sure this tool handles the MC waveform hits just like the data while keeping functionality for other MC truth information.

Other downstream tools will need to be adjusted; I will open separate PRs for each of those tools.

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • [N/A] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • [N/A] For every new usage, there is a reason the data must be on the heap
  • [N/A] For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

See Andrew's PR for details (#324). If you want to use the MC waveform hits, ensure the configuration for PhaseIITreeMaker has both IsData 0 (indicating it is MC) and PMTWaveformSim 1. Setting the latter to 0 will use the default MC hits created by summing the individual photon hits in the ClusterFinder tool

S81D added 2 commits January 6, 2025 13:02
From Andrew's changes, MC now has a waveform simulator that ClusterFinder handles as data-like hits. As a result we must adjust some of the logic used by downstream tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant