EventSelector modifications for new MC waveform hits #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
See PR #329 for more details on why we need to alter downstream tools. For the PMTs,
EventSelector
assumes MC hits are coming from the MC cluster map. For the new MC waveform tool (#324) theClusterFinder
tool handles the MC hits in an identical fashion to the data hits. We therefore need to adjust some of the logic to allow for this tool to use "data" PMT clusters with MC MRD hits, truth information, etc...Checklist before submitting your PR
new
usage, there is a reason the data must be on the heapnew
there is adelete
, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
This PR (just like #329) is dependent on Andrew's new MC waveform tool (#324).