Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSelector modifications for new MC waveform hits #330

Open
wants to merge 2 commits into
base: Application
Choose a base branch
from

Conversation

S81D
Copy link
Contributor

@S81D S81D commented Jan 6, 2025

Describe your changes

See PR #329 for more details on why we need to alter downstream tools. For the PMTs,EventSelector assumes MC hits are coming from the MC cluster map. For the new MC waveform tool (#324) the ClusterFinder tool handles the MC hits in an identical fashion to the data hits. We therefore need to adjust some of the logic to allow for this tool to use "data" PMT clusters with MC MRD hits, truth information, etc...

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • [N/A] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • [N/A] For every new usage, there is a reason the data must be on the heap
  • [N/A] For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

This PR (just like #329) is dependent on Andrew's new MC waveform tool (#324).

S81D added 2 commits January 6, 2025 13:17
Another downstream tool modification to adjust how the tool uses MC hits that are coming from the waveform generator.
Added config variable that tells EventSelector to use MC waveform hits rather than the default MC hits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant