Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLEBNodeFDLaplacian: Make it work with AMREX_USE_EB but with no EB #4083

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

WeiqunZhang
Copy link
Member

This will allow the use of the linear solver when AMReX is built with EB support at compile time but no EB is built at runtime.

X-Ref: ECP-WarpX/WarpX#4865

This will allow the use of the linear solver when AMReX is built with EB
support at compile time but no EB is built at runtime.
@WeiqunZhang WeiqunZhang requested a review from ax3l August 15, 2024 17:45
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@ax3l ax3l self-assigned this Aug 15, 2024
@ax3l ax3l merged commit b82296f into AMReX-Codes:development Aug 15, 2024
71 of 72 checks passed
@ax3l
Copy link
Member

ax3l commented Aug 15, 2024

Oopsi, I see some regressions with this PR in ECP-WarpX/WarpX#5126 (comment) affecting EB-compiled (and EB-runtime-used) tests that now fail to converge.

AMREX_D_TERM(Array4<Real const> const& ecx = edgecent[0]->const_array(mfi);,
Array4<Real const> const& ecy = edgecent[1]->const_array(mfi);,
Array4<Real const> const& ecz = edgecent[2]->const_array(mfi));
auto const& levset = levset_mf.const_array(mfi);
auto const& levset = factory->getVolFrac().const_array(mfi);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug

Suggested change
auto const& levset = factory->getVolFrac().const_array(mfi);
auto const& levset = factory->getLevelSet().const_array(mfi);

ax3l added a commit to ax3l/amrex that referenced this pull request Aug 16, 2024
Fix copy-paste regression from AMReX-Codes#4083
@ax3l ax3l mentioned this pull request Aug 16, 2024
5 tasks
WeiqunZhang pushed a commit that referenced this pull request Aug 16, 2024
## Summary

Fix copy-paste regression from #4083

## Additional background

#4083 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants