-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLEBNodeFDLaplacian: Make it work with AMREX_USE_EB but with no EB #4083
Conversation
This will allow the use of the linear solver when AMReX is built with EB support at compile time but no EB is built at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
Oopsi, I see some regressions with this PR in ECP-WarpX/WarpX#5126 (comment) affecting EB-compiled (and EB-runtime-used) tests that now fail to converge. |
AMREX_D_TERM(Array4<Real const> const& ecx = edgecent[0]->const_array(mfi);, | ||
Array4<Real const> const& ecy = edgecent[1]->const_array(mfi);, | ||
Array4<Real const> const& ecz = edgecent[2]->const_array(mfi)); | ||
auto const& levset = levset_mf.const_array(mfi); | ||
auto const& levset = factory->getVolFrac().const_array(mfi); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug
auto const& levset = factory->getVolFrac().const_array(mfi); | |
auto const& levset = factory->getLevelSet().const_array(mfi); |
Fix copy-paste regression from AMReX-Codes#4083
## Summary Fix copy-paste regression from #4083 ## Additional background #4083 (comment)
This will allow the use of the linear solver when AMReX is built with EB support at compile time but no EB is built at runtime.
X-Ref: ECP-WarpX/WarpX#4865