Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): Add support AWS SAM CLI #473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(aws): Add support AWS SAM CLI #473

wants to merge 2 commits into from

Conversation

simonmcc
Copy link

Overview

Add support for the AWS SAM CLI to the existing AWS plugin

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

sam list resources

Changelog

The AWS plugin can now be used with the AWS SAM CLI.

@simonmcc simonmcc mentioned this pull request Jun 19, 2024
Closed
4 tasks
SimonBarendse
SimonBarendse approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution, Simon! 🙌

hculea
hculea reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@hculea hculea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - Otherwise this looks good, thank you for your contribution!

plugins/aws/sam.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hculea hculea hculea left review comments

@SimonBarendse SimonBarendse SimonBarendse approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonmcc @SimonBarendse @hculea