Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Add support AWS SAM CLI #472

Closed
wants to merge 1 commit into from

Conversation

simonmcc
Copy link

Overview

Add support for the AWS SAM CLI to the existing AWS plugin

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

sam list resources

Changelog

The AWS plugin can now be used with the AWS SAM CLI.

Copy link
Contributor

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@simonmcc simonmcc closed this Jun 19, 2024
@simonmcc simonmcc deleted the add-aws-sam-cli branch June 19, 2024 09:26
@SimonBarendse
Copy link
Member

Hi Simon (great name btw 😜 ) @simonmcc, may I ask what prompted you to close this PR? I believe it would have made a great addition!

@simonmcc simonmcc restored the add-aws-sam-cli branch June 19, 2024 09:32
@simonmcc
Copy link
Author

simonmcc commented Jun 19, 2024

@SimonBarendse (awesome name!!) I was struggling to get the signing check to re-run, so took the lazy approach & recreated the PR: #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants