Merge pull request #1398 from 18F/feature/subset_of_the_big_one

[Feature] Add screen resolutions chart
18F · Oct 16, 2024 · 9c3606b · 9c3606b
2 parents 5f17784 + eff4b90
commit 9c3606b
Show file tree

Hide file tree

Showing 68 changed files with 23,019 additions and 2,015 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -65,7 +65,7 @@ jobs:
       - lint-js
       - lint-styles
       - test
-    if: github.ref == 'refs/heads/develop'
+    if: github.ref == 'refs/heads/feature/subset_of_the_big_one'
     uses: 18F/analytics.usa.gov/.github/workflows/deploy.yml@develop
     with:
       API_APP_NAME: ${{ vars.API_APP_NAME_DEV }}

diff --git a/_includes/analytics_definitions.html b/_includes/analytics_definitions.html
@@ -244,9 +244,9 @@ <h3 id="report_realtime_top_pages" class="usa-accordion__heading">
                 <a href="#dimension_operating_system">operating_system</a>
               </li>
               <li>
-                Description: devices, web browsers, and operating systems users
-                were on when interacting with DAP-participating government
-                websites in the past 30 days.
+                Description: devices, web browsers, operating systems, and
+                screen resolutions that users were on when interacting with
+                DAP-participating government websites in the past 30 days.
               </li>
             </ul>
           </div>
@@ -646,19 +646,39 @@ <h4 id="dimension_screen_name" class="usa-accordion__heading">
               </span>
             </div>
 
-            <h4 id="dimension_source_medium" class="usa-accordion__heading">
+            <h4 id="dimension_screen_resolution" class="usa-accordion__heading">
               <button
                 type="button"
                 class="usa-accordion__button"
                 aria-expanded="false"
                 aria-controls="dimensions__section16"
               >
-                Source medium
+                Screen resolution
               </button>
             </h4>
             <div
               id="dimensions__section16"
               class="usa-accordion__content usa-prose"
+            >
+              <span>
+                The width and height (in pixels) of the screen from which user
+                activity originates.
+              </span>
+            </div>
+
+            <h4 id="dimension_source_medium" class="usa-accordion__heading">
+              <button
+                type="button"
+                class="usa-accordion__button"
+                aria-expanded="false"
+                aria-controls="dimensions__section17"
+              >
+                Source medium
+              </button>
+            </h4>
+            <div
+              id="dimensions__section17"
+              class="usa-accordion__content usa-prose"
             >
               <span>
                 A source is a representation of the publisher or inventory

diff --git a/_includes/header.html b/_includes/header.html
@@ -1,4 +1,4 @@
-<header id="analytics-header" class="grid-row">
+<header id="analytics-header" class="grid-row padding-3">
   <h1>
     <img
       src="{{ site.baseurl }}/images/analytics.svg"