feat(FPI): Make storage maps usable by querying the node #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
changed the title
igamigo
force-pushed
the
igamigo-fpi-maps
branch
from
d732b42 to
b1ca66c
Compare
tomyrd
approved these changes
Jan 7, 2025
| @@ -181,7 +184,22 @@ impl ProtoAccountStateHeader { | |||
| } | |||
| }; | |||
|
|
|||
| Ok(StateHeaders { account_header, storage_header, code }) | |||
| // Get map values into slot |-> (key, value, proof) mapping | |||
There was a problem hiding this comment.
I would change this to:
Suggested change
| // Get map values into slot |-> (key, value, proof) mapping | |
| // Get map values into slot |-> [proof0, proof1, ...] mapping |
As I don't think we are storing the keys and values here.
| @@ -217,7 +236,10 @@ impl AccountProof { | |||
| account_hash: Digest, | |||
| state_headers: Option<StateHeaders>, | |||
| ) -> Result<Self, AccountProofError> { | |||
| if let Some(StateHeaders { account_header, storage_header: _, code }) = &state_headers { | |||
| if let Some(StateHeaders { | |||
| account_header, storage_header: _, code, .. | |||
There was a problem hiding this comment.
I think this could work too:
Suggested change
| account_header, storage_header: _, code, .. | |
| account_header, code, .. |
| } | ||
|
|
||
| let headers = if include_headers && account_id.is_public() { | ||
| // Because we set `include_headers` to true, for any public account we requeted we |
There was a problem hiding this comment.
Suggested change
| // Because we set `include_headers` to true, for any public account we requeted we | |
| // Because we set `include_headers` to true, for any public account we requested we |
| /// | ||
| /// At execution, the client queries the node and retrieves account-related data, based on | ||
| /// what's defined in `foreign_accounts` | ||
| pub fn with_foreign_accounts( |
There was a problem hiding this comment.
We could end up with duplicate accounts when using with_foreign_accounts/with_public_foreign_accounts/with_private_foreign_accounts. Maybe we could do a duplicate check when inserting or store them in a BTreeMap/Set. Plus, do we need all 3 methods? Maybe we could have just the first one, the creation of the ForeignAccount items would need to be done by the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes following up 0xPolygonMiden/miden-node#598 in order to allow using storage maps on FPI.
This was a feature requested by pioneers.