Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable requesting account storage map information #596

Closed
igamigo opened this issue Dec 19, 2024 · 4 comments
Closed

Enable requesting account storage map information #596

igamigo opened this issue Dec 19, 2024 · 4 comments
Assignees
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Dec 19, 2024

To enable FPI, GetAccountProofs was introduced. This endpoint returns a proof of the account's existence, alongside state headers: AccountHeader, StorageHeader and AccountCode. There is an implicit limitation to this workflow: StorageHeader only contains the top-level storage slot items (eg, for storage maps, only the root is returned, without any actual map information), so any transaction that attempts to get data related to a foreign account's storage map would fail.

A mechanism should be provided to allow querying for a specific item/key, in a way that enables FPI with procedures that look into any item, not just top-level values. I'm not sure if we would prefer to retrieve individual storage slots, or if it could be made more granular in order to request specific values of storage maps.

As a side note, if a workaround is needed with more urgency, maybe we could (in the client) get the full account object with the GetAccountDetails endpoint for now to work around this limitation.

@Dominik1999
Copy link
Contributor

@Mirko-von-Leipzig @bobbinth can you prioritize this? Its a user request, and we like our users!

@bobbinth bobbinth added this to the v0.7 milestone Dec 19, 2024
@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Dec 20, 2024

imo we should implement the quick-fix @igamigo suggested in the client. Given that our current user-base is small the impact should be minor, and this gets the users something useable asap, without being majorly impacted by the holiday delays.

We still need to flesh out a proper design for handling arbitrarily large request ranges which would form part of the solution for this iiuc.

@igamigo
Copy link
Collaborator Author

igamigo commented Dec 30, 2024

I forgot to mention here that I did implement the quick fix on the client to unblock the pioneers.

Additionally I've added the parameters for querying account maps and map keys for each account on GetAccountProofs on #598. FPI integration tests on the client are passing (0xPolygonMiden/miden-client#645 implements these changes).

@igamigo
Copy link
Collaborator Author

igamigo commented Jan 13, 2025

Closed by #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants