Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 5 & 6 #22

Merged
merged 26 commits into from
Jun 10, 2023
Merged

Feature 5 & 6 #22

merged 26 commits into from
Jun 10, 2023

Conversation

devahmedshendy
Copy link
Contributor

@devahmedshendy devahmedshendy commented Apr 30, 2023 •
edited
Loading

@devahmedshendy devahmedshendy self-assigned this Apr 30, 2023
@0xLeif 0xLeif changed the title Feature 5 & 5 Feature 5 & 6 Apr 30, 2023
0xLeif
0xLeif reviewed May 16, 2023
View reviewed changes
Copy link
Member

@0xLeif 0xLeif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Left some comments, let's keep working on this. Chat in Discord if needed!

OpenWeather/App/Favorites/FavoritesScreen.swift Outdated Show resolved Hide resolved
OpenWeather/App/Favorites/FavoritesViewModel.swift Outdated Show resolved Hide resolved
OpenWeather/Data/Adapters/LocationAdapter.swift Outdated Show resolved Hide resolved
OpenWeather/Persistence/Database/Implementation/SQLiteDatabaseService.swift Outdated Show resolved Hide resolved
OpenWeather/App/Favorites/FavoritesViewModel.swift Outdated Show resolved Hide resolved
OpenWeather/Persistence/Database/Implementation/SQLiteDatabaseService.swift Outdated Show resolved Hide resolved
OpenWeather/Utilities/Operators/==.swift Outdated Show resolved Hide resolved
OpenWeather/App/Search/SearchLocationScreen.swift Outdated Show resolved Hide resolved
@devahmedshendy devahmedshendy mentioned this pull request May 18, 2023
Open
0xLeif
0xLeif reviewed May 30, 2023
View reviewed changes
project.yml Outdated Show resolved Hide resolved
@devahmedshendy devahmedshendy merged commit a9d9bf7 into main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xLeif 0xLeif 0xLeif approved these changes

Assignees

@devahmedshendy devahmedshendy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devahmedshendy @0xLeif