Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need an alternative when failed to create SQLite database using GRDB #23

Open
devahmedshendy opened this issue May 18, 2023 · 1 comment
Open

We need an alternative when failed to create SQLite database using GRDB #23

devahmedshendy opened this issue May 18, 2023 · 1 comment

Comments

@devahmedshendy
Copy link
Contributor 

          I think we could return an optional and then just deal with it later if it is nil maybe? 🤔

Originally posted by @0xLeif in #22 (comment)
@devahmedshendy
Copy link
Contributor Author

If an in-memory alternative to be used, then user must be informed in some way that all favorites are not persistent.

@0xLeif 0xLeif mentioned this issue May 18, 2023
Merged
devahmedshendy added a commit that referenced this issue May 20, 2023
@devahmedshendy
Mentioned ticket #23
491ce4b
devahmedshendy added a commit that referenced this issue Jun 10, 2023
@devahmedshendy
Feature 5 & 6 (#22)
a9d9bf7 
* Initial TDD for DatabaseService

* Add GRDB dependency using project.yml instead

* Write test for inserting favorite location

* Remove constants of sqlColumn/sqlTable

* Fix: uuid shouldn't be saved, but is string representation

* Clean up

* Refactor sql statements to find location by name, lat, long instead

* Use LocationProvider, and make view models as StateObject

* Add created_at to fetch favorites as sorted

* Change some 'summary' namings to 'favorites'

* Implement Feature 5 & 6

* DatabaseError, memory leak, cleanup

* Apple fixes

* Rename database to databaseService

* refactor LocationAdapterTest

* Mentioned ticket #23

* rewrite/add-more tests for SQLiteDatabaseServiceTests

* Write unit test for toggleLocation of SearchLocationViewModel

* Divide unit test for toggleFavorite in SearchLocationViewModel to search add/remove from favorites

* Add tests for FavoritesViewModel

* Add test for weather summary for FavoritesViewModel

* Use tagged version for GRDB than master branch

* Resolve conversation

* Fix project.yml syntax, 'from' instead of 'branch'

* Sync unfavorites with search result

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devahmedshendy