This repository has been archived by the owner on Dec 15, 2024. It is now read-only.
[Adriyst's work !]Compaitibility script no longer breaks to collections changes in 3.10 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
changed the title
ivixvi
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
LGTM
以下を確認しました
- python2の互換性用スクリプトであったこと
- python3.10でエラーが再現すること
- python3.10で属性としてでなく、モジュールとして切り出されると3.9のドキュメントで確認
- python3.9以前でも
import collections.abcでインポートできエラーが発生しないこと
Deprecated since version 3.3, will be removed in version 3.10: Moved Collections Abstract Base Classes to the collections.abc module. For backwards compatibility, they continue to be visible in this module through Python 3.9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for merging the commit against the upstream created by Adriyst into zztkm/pyton-pptx(thins repo).