Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add card type category #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mmougy
Copy link
Contributor

@mmougy mmougy commented Jan 18, 2025

In order to know if a card is a player card or an encounter card
adding a category of type might be helpful

It implements the definition from Rules Reference 1.6:

@jordanweiler
Copy link
Contributor

Don't we already mark the card's faction_code as encounter? Is this duplicating something we already can figure out?

@Kamalisk
Copy link
Collaborator

I guess this is useful if you wanted to filter by those types without loading card data, but yes the data is already in the card data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants