[GMW][AoA] Fix campaign faction code

[mmougy]

To maintain consistency with other campaign boxes:
campaign cards whether player card or encounter cards should have the faction: "campaign"

following sets are currently referenced with the faction "encounter", but in fact are campaign only cards:

• Galaxy's Most Wanted

  • Challenge

• Age of Apocalypse

  • Overseer (but not Prelate, which are needed for the Apocalypse villain)
  • Mission
  • Age of Apocalypse

This is just a proposal, let me know if you agree with this, or see things other way :)

[Kamalisk]

I do think campaign should just be the player cards (as they are not basic aspect they are campaign)
But I don't think it makes a big deal for these to be marked as campaign, aside from things which check if cards are player cards or encounter cards, probably just checks the faction is encounter, but if some are already campaign, then its broken already :P

[mmougy]

I do think campaign should just be the player cards (as they are not basic aspect they are campaign)

your solution improves data consistency, but i slightly disagree with your assertion

some campaign cards are explicitly basic:

• Adrenal Stims
• Fandral
• Safehouse
• Blink
  ...

and some villain set cards are explicitly basic:

• Odin
• Robert Kelly

also few cards ability interact specifically with basic cards

• Superpower Adaptation
• The Power in All of Us

But I don't think it makes a big deal for these to be marked as campaign, aside from things which check if cards are player cards or encounter cards,

indeed i don't think it makes a big deal, in fact nobody complains about this

probably just checks the faction is encounter

i think so.
it would be nice if the filter selector worked this way:

• Only Player Cards
• Only Encounter Cards
• Only Campaign cards
• All Cards

but if some are already campaign, then its broken already :P

currently all campaign player cards and most of campaign encounter cards have the faction "campaign"
the mainly inconsistency is for the set "Challenge" which has the faction encounter

---

ideally, i think all campaign sets should have the (not yet defined) type "campaign" instead of "modular"
and the "campaign" faction should not be used, but replaced by "basic" or "encounter" or no value.
but since most filtering feature are based on faction, it implies changes on marvelcdb. i'll make some test in this way

but for now i can set the faction "campaign" for just the campaign player cards
and set the faction "encounter" for just the campaign encounter cards