revert back to extract_from=None as default

zytedata · Jan 31, 2024 · e766bc4 · e766bc4
1 parent c8c3b19
commit e766bc4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/test_ecommerce.py b/tests/test_ecommerce.py
@@ -349,7 +349,7 @@ def test_metadata():
                 },
                 "extract_from": {
                     "anyOf": [{"type": "string"}, {"type": "null"}],
-                    "default": "browserHtml",
+                    "default": None,
                     "title": "Extraction source",
                     "description": (
                         "Whether to perform extraction using a browser request "

diff --git a/zyte_spider_templates/spiders/base.py b/zyte_spider_templates/spiders/base.py
@@ -66,7 +66,7 @@ class BaseSpiderParams(BaseModel):
             "Whether to perform extraction using a browser request "
             "(browserHtml) or an HTTP request (httpResponseBody)."
         ),
-        default=ExtractFrom.browserHtml,
+        default=None,
         json_schema_extra={
             "enumMeta": {
                 ExtractFrom.browserHtml: {