-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version number to 5.0.0 #546
base: master
Are you sure you want to change the base?
Conversation
Since we already introduced breaking API changes, so there should be a way to detect those changes for users.
Allows preprocesser #if statements to use version macros.
Unrelated but worth mentioning: I wish we could have a tagged release for v4 with meson, so I could add Zydis to meson's WrapDB without waiting for v5 release :) |
@mappzor and me worked on the APX branch a while ago and our work is mostly finished by now. We have to polish some of the APIs before we can trigger the V5 release. I hope to find some time for this soon. Not sure how much effort it would be to backport the Meson support to V4. |
I'll make a new PR for the v4 meson support. |
Thank you! I'll then make sure to create a v4 maintenance branch first, in which we should merge your PR and backport any other non breaking fix from master until V5 gets released. |
We should still bump the version already, even if we don't release v5 yet. I think that's how most projects do it: once you introduce the first breaking change and fork off a maintenance branch for current major version, you bump version on |
Since we already introduced breaking API changes, so there should be a way to detect those changes for users.