-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce hint to force specific code set for Code-128 encoding #1411
Introduce hint to force specific code set for Code-128 encoding #1411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fine, just some minor comments
core/src/test/java/com/google/zxing/oned/Code128WriterTestCase.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/zxing/oned/OneDimensionalCodeWriter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
============================================
- Coverage 79.26% 79.25% -0.01%
- Complexity 4367 4382 +15
============================================
Files 251 251
Lines 14641 14663 +22
Branches 3017 3024 +7
============================================
+ Hits 11605 11621 +16
- Misses 2152 2154 +2
- Partials 884 888 +4
Continue to review full report at Codecov.
|
Hi,
This PR enables forcing the code set for the Code128 encoder.
This feature is important when trying to exactly recreate a barcode that has been scanned (see CatimaLoyalty/Android#244).
The problem and the change are described on this post on the Google Group. I ported and tested the change for the master branch.
Thanks for considering this PR.