-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule editor UI #94
Rule editor UI #94
Conversation
this contains a lot of code similar to edit_panel
dc0540f
to
0bdb9bc
Compare
Looks good! Something that's a little confusing: When you have the rule editor open, you can still save a graph. But I think what this does is just save the currently selected graph. I would have expected this to save the whole rule as a lemma to a file. Currently all the rules are stored in a single file, but if we want users to be able to share lemmas between each other, we probably want each rule to be in a separate file. So maybe instead of having |
If you click on 'Save rule' while the diagram is not well-formed, for instance if it has a boundary node not connected to anything, then it throws an exception instead of telling the user the diagram is not well-formed. |
Also maybe something not for this PR: Have a button that allows the user to switch the LHS and RHS. Or maybe something that allows you to automatically create the reverse rule? |
@boldar99 is working on the side panel for rewrite rules (#71). We can have a button there to apply the rewrite rule in the forward or backward direction. |
@jvdwetering the rules are now saved to individual files and the save button in the file menu has the right behavior. I have also added a function to check the rule and warn the user. |
Closes #83