-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvement: Rewrite rules #71
Comments
Hmm, I'm not sure I'm a fan of this idea. Wouldn't that make the sidebar very crowded? We have some nice real estate on top of the diagram, so why not use it? |
Using tabs sounds like a nice idea :) |
We should also allow the user to delete custom rewrites from the UI. |
I think we could also add different tab names based on subfolders in the folder containing the custom rewrite rules. This would make sense if we expect people to be adding a lot of custom rewrite rules. A design decision we want to consider is whether a rewrite rule can appear in multiple tabs. For instance, should Z-spider fusion only appear in Basic rules, or also in the ZXW rule set and the ZH rule set? |
Is it possible to add an option to change from horizontal tabs to vertical tabs? Most browsers support this. That would look a bit like Boldi's suggestion. I fell that horizontal list of rewrites is a bit inconvenient if you have a lot of custom rewrites because then you need to scroll horizontally. |
@jvdwetering can you also add these simplifications as a tab? |
I believe there is some built in Qt feature that allows you to switch being a horizontal layout and a vertical layout. |
I have added these simplification routines in this commit a3d6260 |
The horizontal tabbed interface we have here does not scroll when the there are a lot of rewrites and it compresses the text on the button such that you can't read the full name of the rewrite. |
The side panel can have the rewrites, simplification routines and the proof steps. The code for sidebar of edit mode might be useful for implementing this.
The text was updated successfully, but these errors were encountered: