Fix crash due to wrong type for snap-granularity combo pref dict key.

Fixes #214.
zxcalc · Dec 16, 2023 · 949ac00 · 949ac00
1 parent 9822dda
commit 949ac00
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/test/test_mainwindow.py b/test/test_mainwindow.py
@@ -21,6 +21,7 @@
 from zxlive.edit_panel import GraphEditPanel
 from zxlive.mainwindow import MainWindow
 from zxlive.proof_panel import ProofPanel
+from zxlive.settings_dialog import SettingsDialog
 
 
 @pytest.fixture
@@ -89,3 +90,8 @@ def test_start_derivation(app: MainWindow, qtbot: QtBot) -> None:
     app.close_action.trigger()
     assert app.tab_widget.count() == 1
     assert not app.export_tikz_proof.isEnabled()
+
+def test_settings_dialog(app: MainWindow) -> None:
+    dialog = SettingsDialog(app)
+    dialog.show()
+    dialog.close()
diff --git a/zxlive/common.py b/zxlive/common.py
@@ -34,7 +34,7 @@ class ToolType(IntEnum):
 defaults: Dict[str,Any] = {
     "path/custom-rules": "lemmas/",
     "color-scheme": "modern-red-green",
-    "snap-granularity": 4,
+    "snap-granularity": '4',
 
     "tikz/boundary-export": pyzx.settings.tikz_classes['boundary'],
     "tikz/Z-spider-export": pyzx.settings.tikz_classes['Z'],

diff --git a/zxlive/settings_dialog.py b/zxlive/settings_dialog.py
@@ -61,8 +61,8 @@ def __init__(self, main_window: MainWindow) -> None:
         vlayout.addWidget(w)
         self.add_setting(form_general, "path/custom-rules", "Custom rules path", 'folder')
         self.add_setting(form_general, "color-scheme", "Color scheme", 'combo',data=color_schemes)
-        self.add_setting(form_general, "snap-granularity", "Snap-to-grid granularity", 'combo', 
-                         data={2: "2", 4: "4", 8: "8", 16: "16"})
+        self.add_setting(form_general, "snap-granularity", "Snap-to-grid granularity", 'combo',
+                         data = {'2': "2", '4': "4", '8': "8", '16': "16"})
         self.prev_color_scheme = self.settings.value("color-scheme")
         vlayout.addStretch()