Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow and build #3

Closed
wants to merge 1 commit into from
Closed

Conversation

g4ze
Copy link

@g4ze g4ze commented May 31, 2024

[opened by mistake, sorry]

@g4ze g4ze closed this May 31, 2024
@jschauma
Copy link
Collaborator

jschauma commented Jun 1, 2024

@g4ze how come you closed the PR? This looks like it might be useful to address your issue #2 , no?

@g4ze
Copy link
Author

g4ze commented Jun 1, 2024

Hey! sure!
We were planning on developing and maintaining a pypi for our intelowl integration, as dicussed here

We forked the repo with the intent of publishing a pipy package ourselves for ease of use and integrations.

It would be super convenient for us to work with a package.
By mistake i created the pull request for this repo :p
However, idts it would be a problem for us if you publish it...

@jschauma
Copy link
Collaborator

jschauma commented Jun 1, 2024

We can (and probably should) do two things here that would help you as well as anybody else wanting to use the tool:

  • Convert the standalone tool into a package, so you can import domaincheck and then e.g. call domaincheck.performAllChecks(domain) . The output is stashed in an internal data structure that you can easily access or dump via json.dumps or some of the print* functions in the tool.
  • Create a pypi package and upload it, so that there is no confusion around who supplied the tool.

I've opened issue #4 for the module part, and issue #2 already exists for the pypi package. I'll try to take a look maybe in the coming week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants