Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented search bar for giphy #324

Closed
wants to merge 3 commits into from
Closed

Implemented search bar for giphy #324

wants to merge 3 commits into from

Conversation

RinsolaO
Copy link
Contributor

@RinsolaO RinsolaO commented Sep 2, 2021

@Davien21
Copy link
Contributor

Davien21 commented Sep 2, 2021 •
edited
Loading

Hi. The search bar should only be on the /giphy route
it's not supposed to read: Search Zuri - a better placeholder should be Search for gifs

Also, you did not add any reviewer

Evavic44
Evavic44 reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@Evavic44 Evavic44 left a comment •
edited by Davien21
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought the package-lock.json file should be gitignored?

@Davien21
Copy link
Contributor

Davien21 commented Sep 2, 2021

@Evavic44 - the package-lock.json doesn't have to be ignored

@Davien21 Davien21 closed this Sep 2, 2021
@Evavic44
Copy link
Contributor

Evavic44 commented Sep 2, 2021

@Evavic44 - the package-lock.json doesn't have to be ignored

Oh, okay boss.

@RinsolaO
Copy link
Contributor Author

RinsolaO commented Sep 2, 2021 •
edited
Loading

https://zuriplugin.vercel.app/

did you see this ?

The search bar at the top right corner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evavic44 Evavic44 Evavic44 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RinsolaO @Davien21 @Evavic44 @olimeed