Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Polish sidebar #332

Merged
merged 7 commits into from
Feb 20, 2024
Merged

feat: Polish sidebar #332

merged 7 commits into from
Feb 20, 2024

Conversation

dan-lee
Copy link
Contributor

@dan-lee dan-lee commented Feb 16, 2024 •
edited
Loading

Fixes ZUP-2752

  • Add nice animation for expanding/collapsing a category
  • Allow to expand/collapse multiple times
  • Center category arrow/chevron
  • Removed auto collapse when switching category
    • Personally, I don't think categories should automatically collapse in a larger documentation. Sometimes I need to jump back and forth between multiple pages, and automatically collapsing categories makes it hard to keep track of where things are, and introduces mental overhead.
Before After
CleanShot.2024-02-16.at.20.59.49.mp4
CleanShot.2024-02-16.at.20.59.01.mp4

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 8:25pm

@dan-lee dan-lee requested review from ntotten and mosch February 16, 2024 20:06
@ntotten
Copy link
Member

ntotten commented Feb 16, 2024 •
edited
Loading

Some of the spacing seems off
image

CleanShot 2024-02-16 at 15 07 58@2x

@dan-lee
Copy link
Contributor Author

dan-lee commented Feb 16, 2024

@ntotten Good catch, I fixed the spacings (not 100% exactly like before, but should do the trick!)

@ntotten ntotten merged commit 6b55629 into main Feb 20, 2024
6 checks passed
@ntotten ntotten deleted the polish-sidebar branch February 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntotten ntotten Awaiting requested review from ntotten

@mosch mosch Awaiting requested review from mosch

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-lee @ntotten